fixed stack-use-after-scope when assigning message_reader #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for the PR @mvanslobbe , I will check it out. |
|
Brilliant, thank you @mvanslobbe |
jamesdbrock
added a commit
that referenced
this pull request
Oct 11, 2020
fixed stack-use-after-scope when assigning message_reader
This was referenced Oct 11, 2020
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for the great work on this library! Getting started with it has been effortless!
I've hit the same bug as encountered in #27 and solved it in the easiest way possible - by making the copy constructor and assignment operator 're-init' and thus use the const_iterator correctly. In doing so I realize that this is of course less efficient ( init() does do work ) but this fix has the benefit of being correct. Also it doesn't change the behaviour.
There's a unit test in here, which replicates the problem if you run under asan, and shows that the problem is now resolved.
Please let me know what you think.