Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Object Pooling #450

Merged
merged 7 commits into from
Nov 7, 2024
Merged

Remove Object Pooling #450

merged 7 commits into from
Nov 7, 2024

Conversation

jamescourtney
Copy link
Owner

No description provided.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.61%. Comparing base (9b48653) to head (60c569b).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
- Coverage   96.92%   96.61%   -0.31%     
==========================================
  Files         126      124       -2     
  Lines        9784     8843     -941     
  Branches      795      730      -65     
==========================================
- Hits         9483     8544     -939     
- Misses        209      215       +6     
+ Partials       92       84       -8     
Files with missing lines Coverage Δ
src/FlatSharp.Compiler/CompilerOptions.cs 100.00% <ø> (ø)
...mpiler/SchemaModel/BaseReferenceTypeSchemaModel.cs 100.00% <ø> (ø)
...Compiler/SchemaModel/ReferenceStructSchemaModel.cs 92.68% <ø> (-0.66%) ⬇️
...FlatSharp.Compiler/SchemaModel/TableSchemaModel.cs 100.00% <ø> (ø)
...harp.Compiler/SchemaModel/ValueUnionSchemaModel.cs 97.40% <100.00%> (-0.06%) ⬇️
...rc/FlatSharp.Runtime/GeneratedSerializerWrapper.cs 82.06% <ø> (-0.49%) ⬇️
...atSharp.Runtime/Vectors/FlatBufferIndexedVector.cs 80.00% <100.00%> (-4.49%) ⬇️
...time/Vectors/FlatBufferProgressiveIndexedVector.cs 83.67% <100.00%> (-3.10%) ⬇️
...c/FlatSharp.Runtime/Vectors/GreedyIndexedVector.cs 88.23% <100.00%> (-2.78%) ⬇️
src/FlatSharp/FlatBufferVectorHelpers_Greedy.cs 100.00% <100.00%> (ø)
... and 14 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b48653...60c569b. Read the comment docs.

@jamescourtney jamescourtney merged commit 53da419 into main Nov 7, 2024
7 of 8 checks passed
@jamescourtney jamescourtney deleted the remove-poolable branch November 7, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant