Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create output directory if not exists #444

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

sssooonnnggg
Copy link
Contributor

@sssooonnnggg sssooonnnggg commented Oct 23, 2024

If the output directory doesn't exist, the compiler will return directly without any errors, which is a bit confusing.
When the output directory does not exist, try to create it.

chore: create output directory if not exists
@jamescourtney
Copy link
Owner

Apparently all the pipelines are broken. I'll take a look at this soon.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.91%. Comparing base (cf9cd4a) to head (4453709).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #444   +/-   ##
=======================================
  Coverage   96.91%   96.91%           
=======================================
  Files         126      126           
  Lines        9754     9754           
  Branches      792      792           
=======================================
  Hits         9453     9453           
  Misses        209      209           
  Partials       92       92           
Files with missing lines Coverage Δ
src/FlatSharp.Compiler/FlatSharpCompiler.cs 93.43% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf9cd4a...4453709. Read the comment docs.

@jamescourtney jamescourtney merged commit 315b95b into jamescourtney:main Oct 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants