Skip to content

Commit

Permalink
Clean up noop tests: remove TODO in test case
Browse files Browse the repository at this point in the history
  • Loading branch information
jamescooke committed Feb 27, 2019
1 parent 15db017 commit eb05a4a
Showing 1 changed file with 13 additions and 3 deletions.
16 changes: 13 additions & 3 deletions tests/helpers/test_function_is_noop.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,14 @@

@pytest.mark.parametrize(
'code_str', [
'def test():\n pass',
'def test_docstring():\n """This test will work great"""',
'''
def test():
pass
''',
'''
def test_docstring():
"""This test will work great"""
''',
]
)
def test(code_str):
Expand All @@ -20,7 +26,11 @@ def test(code_str):


@pytest.mark.parametrize('code_str', [
'def test_tomorrow():\n # TODO write this test\n result = 1',
'''
def test_tomorrow():
# FIX write this test
result = 1
''',
])
def test_not_noop(code_str):
node = ast.parse(code_str).body[0]
Expand Down

0 comments on commit eb05a4a

Please sign in to comment.