Skip to content

Commit

Permalink
fix: disable ripple effect on Android P
Browse files Browse the repository at this point in the history
Ripple effect has a lot of issues on Android P facebook/react-native#6480

Let's disable it for now and figure out how to fix/workaround it
  • Loading branch information
james-watkin committed Dec 19, 2018
1 parent 2919714 commit aa114be
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/components/TouchableRipple.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { withTheme } from '../core/theming';
import type { Theme } from '../types';

const ANDROID_VERSION_LOLLIPOP = 21;
const ANDROID_VERSION_NOUGAT = 27;

type Props = React.ElementConfig<typeof TouchableWithoutFeedback> & {|
/**
Expand Down Expand Up @@ -83,7 +84,9 @@ class TouchableRipple extends React.Component<Props, void> {
* Whether ripple effect is supported.
*/
static supported =
Platform.OS === 'android' && Platform.Version >= ANDROID_VERSION_LOLLIPOP;
Platform.OS === 'android' &&
Platform.Version >= ANDROID_VERSION_LOLLIPOP &&
Platform.Version <= ANDROID_VERSION_NOUGAT;

render() {
const {
Expand Down

0 comments on commit aa114be

Please sign in to comment.