Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup darwin section #19

Merged
merged 10 commits into from
Mar 2, 2016
Merged

Cleanup darwin section #19

merged 10 commits into from
Mar 2, 2016

Conversation

mitchhentges
Copy link
Member

  • Some contents of util were duplicated for some browsers
  • Firefox had an all option, despite the fact that find() only returns one path
  • There was a file per-browser, even though the contents were identical, except for two strings

mitchhentges
mitchhentges reviewed Feb 29, 2016
View reviewed changes
lib/darwin/util.js
fs = require( 'fs' ),
path = require( 'path' ),
plist = require( 'plist' );
var exec = require('child_process').exec,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just auto-indent going on here

Mitchell Hentges added 2 commits February 29, 2016 18:21
Add firefox-developer to darwin support list, fixes james-proxy#8
4762b67
Merge branch 'master' into cleanup-darwin
7c02c96 
# Conflicts:
#	lib/darwin/chrome-canary.js
#	lib/darwin/index.js
#	lib/detect.js
@tomitm
Copy link

tomitm commented Mar 2, 2016

👍

mitchhentges added a commit that referenced this pull request Mar 2, 2016
@mitchhentges
Merge pull request #19 from mitchhentges/cleanup-darwin
d734a47 
Cleanup darwin section
@mitchhentges mitchhentges merged commit d734a47 into james-proxy:master Mar 2, 2016
@mitchhentges mitchhentges deleted the cleanup-darwin branch March 2, 2016 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchhentges @tomitm