Replace instances of "if X then return false; else return true; fi;" …

…by "return not X;"
james-d-mitchell · Jan 28, 2024 · 5954c94 · 5954c94
1 parent cb6457d
commit 5954c94
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 20 deletions.
diff --git a/lib/grp.gi b/lib/grp.gi
@@ -2955,11 +2955,7 @@ local n,a;
   fi;
 
   a:=AutomorphismGroup(G);
-  if ForAny(GeneratorsOfGroup(a),i->Image(i,H)<>H) then
-    return false;
-  else
-    return true;
-  fi;
+  return not ForAny(GeneratorsOfGroup(a),i->Image(i,H)<>H);
 end );
 
 

diff --git a/lib/kernel.g b/lib/kernel.g
@@ -103,11 +103,7 @@ end;
 ##  </ManSection>
 ##
 IS_SUBSTRING := function( str, sub )
-  if LEN_LIST(sub) > 0 and POSITION_SUBSTRING(str, sub, 0) = fail then
-    return false;
-  else
-    return true;
-  fi;
+  return LEN_LIST(sub) = 0 or POSITION_SUBSTRING(str, sub, 0) <> fail;
 end;
 
 

diff --git a/lib/ratfun1.gi b/lib/ratfun1.gi
@@ -635,11 +635,7 @@ local a,b,fam,i, j,ln,ld,rn,rd;
   od;
   # is there an a-remainder (then a is larger)
   # or are both polynomials equal?
-  if i>0 or i=j then
-    return false;
-  else
-    return true;
-  fi;
+  return not (i>0 or i=j);
 end );
 
 #############################################################################

diff --git a/lib/straight.gi b/lib/straight.gi
@@ -526,11 +526,7 @@ InstallMethod( IsInternallyConsistent,
 
       # If the number of generators is stored then check
       # that only defined positions are accessed.
-      if IsBound( nrgens ) and not IsSubset( defined, gens ) then
-        return false;
-      else
-        return true;
-      fi;
+      return not ( IsBound( nrgens ) and not IsSubset( defined, gens ) );
     end;
 
     len:= Length( lines );