Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote CDI TCK 4.0.12 #659

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Promote CDI TCK 4.0.12 #659

merged 1 commit into from
Oct 12, 2023

Conversation

manovotn
Copy link
Contributor

@netlify
Copy link

netlify bot commented Oct 12, 2023

✅ Deploy Preview for jakartaee-specifications ready!

Name Link
🔨 Latest commit a61f1be
🔍 Latest deploy log https://app.netlify.com/sites/jakartaee-specifications/deploys/6527f3e91c50bb00084ad24a
😎 Deploy Preview https://deploy-preview-659--jakartaee-specifications.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This was referenced Oct 12, 2023
Closed
Closed
@scottmarlow
Copy link
Contributor

@ivargrimstad @starksm64 could one of you please run the promotion script? Thank you!

@starksm64
Copy link
Contributor

It has been promoted.

https://www.eclipse.org/downloads/download.php?file=/jakartaee/cdi/4.0/cdi-tck-4.0.12-dist.zip
288403829e63d049a28e68b145d1f6caa955f8ac28614c4cbae8f45ea2e923dd

@starksm64 starksm64 merged commit 29affaf into jakartaee:master Oct 12, 2023
6 checks passed
@jamezp
Copy link

jamezp commented Oct 12, 2023

Maybe it's still uploading, but the ZIP seems bad.

@manovotn manovotn deleted the cdiTck4012 branch October 12, 2023 16:10
@jamezp
Copy link

jamezp commented Oct 12, 2023

Actually, it seems to be downloading an HTML file. I'm getting a 404 on the download. Maybe I just need patience :)

@scottmarlow
Copy link
Contributor

scottmarlow commented Oct 12, 2023 •
edited
Loading

@starksm64 the contents of the promoted file looks like output from the promotion script but I am not sure.

Starts with:

 <!DOCTYPE html>         
<html lang="en">     
  <head>          
      <meta charset="utf-8">
      <meta http-equiv="X-UA-Compatible" content="IE=edge">
      <meta name="viewport" content="width=device-width, initial-scale=1">
      <!-- Google Tag Manager -->
      <script>(function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start':
         new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0],
         j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src=
         'https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f);
         })(window,document,'script','dataLayer','GTM-5WLCZXC');
      </script>
      <!-- End Google Tag Manager -->     
      <meta name="author" content="Christopher Guindon"/> 
      <meta name="keywords" content="eclipse.org, Eclipse Foundation"/>
      <link rel="shortcut icon" href="//www.eclipse.org/eclipse.org-common/themes/solstice/public/images/favicon.ico"/>
      <title>Not Found | The Eclipse Foundation</title>
      <link rel="stylesheet" href="//www.eclipse.org/eclipse.org-common/themes/solstice/public/stylesheets/quicksilver.min.css?v1.3"/>
      <meta name="description" content="The Eclipse Foundation - home to a global community, the Eclipse IDE, Jakarta EE and over 360 open source projects, including runtimes, tools and frameworks."/>
      <meta property="og:description" content="The Eclipse Foundation - home to a global community, the Eclipse IDE, Jakarta EE and over 360 open source projects, including runtimes, tools and frameworks."/>
      <meta property="og:image" content="https://www.eclipse.org/eclipse.org-common/themes/solstice/public/images/logo/eclipse-foundation-200x200.png"/>
      <meta property="og:title" content="Not Found | The Eclipse Foundation"/>
      <meta property="og:image:width" content="200"/>
      <meta property="og:image:height" content="200"/>
      <meta itemprop="name" content="Not Found | The Eclipse Foundation"/>
      <meta itemprop="description" content="The Eclipse Foundation - home to a global community, the Eclipse IDE, Jakarta EE and over 360 open source projects, including runtimes, tools and frameworks."/>
      <meta itemprop="image" content="https://www.eclipse.org/eclipse.org-common/themes/solstice/public/images/logo/eclipse-foundation-400x400.png"/>
      <meta name="twitter:site" content="@EclipseFdn"/>
      <meta name="twitter:card" content="summary"/>
      <meta name="twitter:title" content="Not Found | The Eclipse Foundation"/>
      <meta name="twitter:url" content="https://www.eclipse.org"/>
      <meta name="twitter:description" content="The Eclipse Foundation - home to a global community, the Eclipse IDE, Jakarta EE and over 360 open source projects, including runtimes, tools and frameworks."/>
      <meta name="twitter:image" content="https://www.eclipse.org/eclipse.org-common/themes/solstice/public/images/logo/eclipse-foundation-400x400.png"/>
      <link href="//fonts.googleapis.com/css?family=Libre+Franklin:400,700,300,600,100" rel="stylesheet" type="text/css"/>
      <script> var eclipse_org_common = {"settings":{"cookies_class":{"name":"eclipse_settings","enabled":1}}}</script>
   </head>

@manovotn
Copy link
Contributor Author

FTR here is the link to the console output of the build which also seems to upload the dist file - https://ci.eclipse.org/cdi/job/CDI-TCK-Release-JDK11/114/console
(@starksm64 should have access, others I am not sure)

@jamezp
Copy link

jamezp commented Oct 12, 2023

Interesting, the file size looks correct in the CI job, but wrong on the site https://download.eclipse.org/jakartaee/cdi/4.0/. It's showing like 20kb which is what's being downloaded.

@scottmarlow
Copy link
Contributor

From comparing console for CDI TCK promotion https://ci.eclipse.org/jakartaee-spec-committee/job/promote-release/287 + earlier promotion of REST TCK promotion https://ci.eclipse.org/jakartaee-spec-committee/job/promote-release/286, the first sign that something is different is:

Rest TCK determines:

for url in '$FILE_URLS'
++ basename https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee10/staged/eftl/jakarta-restful-ws-tck-3.1.4.zip

  • file=jakarta-restful-ws-tck-3.1.4.zip

^ seemed to use the staged REST TCK.

CDI TCK determines:

for url in '$FILE_URLS'
++ basename https://download.eclipse.org/jakartaee/cdi/4.0/cdi-tck-4.0.12-dist.zip

  • file=cdi-tck-4.0.12-dist.zip

^ didn't seem to use the staged CDI TCK.

@scottmarlow
Copy link
Contributor

https://ci.eclipse.org/jakartaee-spec-committee/job/promote-release/283/console seemed to work with similar parameters passing in:

++ basename https://download.eclipse.org/ee4j/cdi/4.0/cdi-tck-4.0.11-dist.zip

  • file=cdi-tck-4.0.11-dist.zip

@scottmarlow
Copy link
Contributor

Hmm, perhaps we need to instead pass in https://download.eclipse.org/ee4j/cdi/4.0/cdi-tck-4.0.12-dist.zip

@scottmarlow
Copy link
Contributor

Thanks Scott, the promoted TCK zip is correct now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottmarlow scottmarlow scottmarlow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manovotn @scottmarlow @starksm64 @jamezp