Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package-level @SequenceGenerator and @TableGenerator #514

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

gavinking
Copy link
Contributor

@gavinking gavinking commented Aug 29, 2023

These two commits:

  1. fix an oversight in "entity local" @SequenceGenerator/@TableGenerator  #406, where the name defaulting for @GeneratedValue was defined only in Javadoc but not in the spec, and
  2. adds package-level @SequenceGenerator and @TableGenerator annotations, as proposed in fallback id generator #511.

@gavinking gavinking linked an issue Aug 29, 2023 that may be closed by this pull request
Copy link
Contributor

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasj lukasj merged commit a1c9c1e into jakartaee:master Sep 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fallback id generator
3 participants