Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix signatures of operations of entity graphs #430

Merged
merged 6 commits into from
Aug 10, 2023
Merged

fix signatures of operations of entity graphs #430

merged 6 commits into from
Aug 10, 2023

Conversation

gavinking
Copy link
Contributor

supersedes #425

@gavinking gavinking mentioned this pull request Aug 8, 2023
Closed
@gavinking
introduce Graph for common operations of EntityGraph and Subgraph
1de18cb 
in preparation for jakartaee#424
@gavinking
introduce Graph.addAttributeNode() and use correct wildcard type
096f84a 
Needed because of "Unchecked generics array creation for varargs parameter"
compiler warning for the varargs version.

see jakartaee#424
@gavinking
use correct upper bounded wildcard type in Graph.addSubgraph()
2e726d3 
see jakartaee#424
@gavinking
clean up addXxxxxSubgraph() operations
1e6346c 
- fix incorrect generic signatures
- add way to navigate to collection elements

see jakartaee#424, jakartaee#411
@gavinking
mark deprecated methods on Graph/EntityGraph forRemoval=true
5f08951 
These operations have simply incorrect generic types, and we now have replacements.

jakartaee#424
@lukasj lukasj linked an issue Aug 10, 2023 that may be closed by this pull request
incorrect generic typing in operations of EntityGraph #424
Closed
@lukasj
Copy link
Contributor

lukasj commented Aug 10, 2023

fixes #424
fixes #411

@lukasj lukasj merged commit f2835cb into jakartaee:master Aug 10, 2023
2 checks passed
@Tomas-Kraus Tomas-Kraus mentioned this pull request Aug 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasj lukasj lukasj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incorrect generic typing in operations of EntityGraph
2 participants
@gavinking @lukasj