Allow retrieving list of values from an Enum type #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduce a new function getValues wich return every values (numeral or string) used to construct the Enum during the declaration process.
|
Thanks! Merging |
|
My pleasure 🙂. @lukejagodzinski Do you know when the new version of Astronomy is going to be (with this PR included) ? |
|
Probably today or tomorrow, so stay tuned. I will inform you here when the new version is published |
|
Installed the package today (it installed 2.5.6) but it looks like the getValues() function, is not recognized: TypeError: UserRole.getValues is not a function. |
|
@eviatarkhen sorry forgot to publish the new version. Did it just now. You can update to 2.5.7 |
|
Thanks, appreciating the fast response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce a new function
getValueswhich return every values used to construct the Enum during the declaration process.This is the implementation of #668.