Skip to content

Commit

Permalink
Fix PR Review Comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jparth603 committed May 31, 2024
1 parent 405c254 commit 35753e0
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions traffic_ops/traffic_ops_golang/login/login.go
Original file line number Diff line number Diff line change
Expand Up @@ -185,13 +185,8 @@ func LoginHandler(db *sqlx.DB, cfg config.Config) http.HandlerFunc {
// be a successful login.
triedAuthentication, authenticated = clientCertAuthentication(w, r, db, cfg, dbCtx, cancelTx, &form, authenticated)

// skipped certificate-based auth, log and continue
if !triedAuthentication {
log.Infof("skipped certificate-based auth because either no certs provided by the client or no configuration is set")
}

// Failed certificate-based auth, perform standard form auth
if triedAuthentication && !authenticated {
if !authenticated {
if form.Username == "" {
log.Infof("could not extract UID from client certificate or HTTP header & could not successfully authenticate using client certificates")
} else {
Expand Down

0 comments on commit 35753e0

Please sign in to comment.