Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable usestdlibvars linter #6249

Merged

Conversation

mmorel-35
Copy link
Contributor

Description

  • enable usestdlibvars linter
  • uses standard constants or vars instead of their values.

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 requested a review from a team as a code owner November 24, 2024 11:41
@mmorel-35 mmorel-35 requested a review from jkowall November 24, 2024 11:41
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.44%. Comparing base (3f8c2e7) to head (85c4073).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/es/wrapper/wrapper.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6249   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files         355      355           
  Lines       20149    20149           
=======================================
  Hits        19433    19433           
  Misses        528      528           
  Partials      188      188           
Flag Coverage Δ
badger_v1 8.31% <0.00%> (ø)
badger_v2 1.67% <0.00%> (ø)
cassandra-4.x-v1 14.39% <0.00%> (ø)
cassandra-4.x-v2 1.61% <0.00%> (ø)
cassandra-5.x-v1 14.39% <0.00%> (ø)
cassandra-5.x-v2 1.61% <0.00%> (ø)
elasticsearch-6.x-v1 18.60% <0.00%> (ø)
elasticsearch-7.x-v1 18.68% <0.00%> (ø)
elasticsearch-8.x-v1 18.84% <0.00%> (-0.01%) ⬇️
elasticsearch-8.x-v2 1.67% <0.00%> (+<0.01%) ⬆️
grpc_v1 9.44% <0.00%> (ø)
grpc_v2 6.98% <0.00%> (ø)
kafka-v1 8.88% <0.00%> (ø)
kafka-v2 1.67% <0.00%> (ø)
memory_v2 1.67% <0.00%> (ø)
opensearch-1.x-v1 18.73% <0.00%> (+<0.01%) ⬆️
opensearch-2.x-v1 18.72% <0.00%> (ø)
opensearch-2.x-v2 1.66% <0.00%> (-0.01%) ⬇️
tailsampling-processor 0.46% <0.00%> (ø)
unittests 95.35% <75.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@yurishkuro yurishkuro changed the title enable usestdlibvars linter Enable usestdlibvars linter Nov 24, 2024
@yurishkuro yurishkuro merged commit 49f33a4 into jaegertracing:main Nov 24, 2024
51 of 53 checks passed
@mmorel-35 mmorel-35 deleted the golangci-lint/usestdlibvars branch November 24, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants