Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OTEL component host instead of no op host for prod code #6085

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

chahatsagarmain
Copy link
Contributor

@chahatsagarmain chahatsagarmain commented Oct 14, 2024

Which problem is this PR solving?

Description of the changes

  • Utilizing OTEL component host in place of no op host

How was this change tested?

  • make lint test

Checklist

Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
yurishkuro
yurishkuro previously approved these changes Oct 14, 2024
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro yurishkuro enabled auto-merge (squash) October 14, 2024 22:40
@yurishkuro yurishkuro changed the title OTEL component host instead of no op host for prod code Use OTEL component host instead of no op host for prod code Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.94%. Comparing base (c7e9f3d) to head (8254b79).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6085   +/-   ##
=======================================
  Coverage   96.94%   96.94%           
=======================================
  Files         352      352           
  Lines       16717    16719    +2     
=======================================
+ Hits        16206    16208    +2     
  Misses        328      328           
  Partials      183      183           
Flag Coverage Δ
badger_v1 7.99% <0.00%> (-0.01%) ⬇️
badger_v2 1.84% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v1 15.75% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v2 1.77% <0.00%> (-0.01%) ⬇️
cassandra-5.x-v1 15.75% <0.00%> (-0.01%) ⬇️
cassandra-5.x-v2 1.77% <0.00%> (-0.01%) ⬇️
elasticsearch-6.x-v1 19.05% <0.00%> (-0.02%) ⬇️
elasticsearch-7.x-v1 19.12% <0.00%> (+<0.01%) ⬆️
elasticsearch-8.x-v1 19.30% <0.00%> (-0.02%) ⬇️
elasticsearch-8.x-v2 1.84% <0.00%> (-0.01%) ⬇️
grpc_v1 9.37% <75.00%> (+0.02%) ⬆️
grpc_v2 7.12% <0.00%> (-0.01%) ⬇️
kafka-v1 9.68% <0.00%> (-0.01%) ⬇️
kafka-v2 1.84% <0.00%> (-0.01%) ⬇️
memory_v2 1.84% <0.00%> (-0.01%) ⬇️
opensearch-1.x-v1 19.17% <0.00%> (+<0.01%) ⬆️
opensearch-2.x-v1 19.17% <0.00%> (+<0.01%) ⬆️
opensearch-2.x-v2 1.84% <0.00%> (-0.01%) ⬇️
tailsampling-processor 0.49% <0.00%> (-0.01%) ⬇️
unittests 95.75% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro dismissed their stale review October 14, 2024 22:48

in plugin/storage/factory.go:129 the factory is created via different constructor, where host will be nil.

Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
@yurishkuro yurishkuro merged commit bec885e into jaegertracing:main Oct 16, 2024
49 checks passed
chahatsagarmain added a commit to chahatsagarmain/jaeger that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid use of noopHost in prod code
2 participants