-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use OTEL component host instead of no op host for prod code #6085
Use OTEL component host instead of no op host for prod code #6085
Conversation
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6085 +/- ##
=======================================
Coverage 96.94% 96.94%
=======================================
Files 352 352
Lines 16717 16719 +2
=======================================
+ Hits 16206 16208 +2
Misses 328 328
Partials 183 183
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
in plugin/storage/factory.go:129 the factory is created via different constructor, where host will be nil.
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test