[cassandra] Prevent fallback to old schema for operation names table in case of db issues #6061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… DB issues - Fixes jaegertracing#432 - Return and handle error from operation names storage contructor and its dependencies span writer and span reader Signed-off-by: Arunvel Sriram <arunvelsriram@gmail.com>
arunvelsriram
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6061 +/- ##
==========================================
- Coverage 96.91% 96.90% -0.01%
==========================================
Files 349 349
Lines 16587 16598 +11
==========================================
+ Hits 16076 16085 +9
- Misses 328 329 +1
- Partials 183 184 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Oct 6, 2024
Signed-off-by: Arunvel Sriram <arunvelsriram@gmail.com>
yurishkuro
changed the title
Saumya40-codes
pushed a commit
to Saumya40-codes/jaeger
that referenced
this pull request
Oct 14, 2024
…in case of db issues (jaegertracing#6061) ## Which problem is this PR solving? - Resolves jaegertracing#432 - jaegertracing#432 (comment) ## Description of the changes The current [operation names table check logic](https://github.com/jaegertracing/jaeger/blob/main/plugin/storage/cassandra/spanstore/operation_names.go#L97-L99) creates `OperationNamesStorage` instance pointing to old schema table in case of issues with Cassandra. - Check for the existence of old schema table before fallback - Make `OperationNamesStorage` constructor `NewOperationsStorage` to return `error` if both old and new tables doesn't exist or both of their existence cannot be checked. Since there was no `error` returned from `NewOperationsStorage` earlier had to update the dependencies and handle the `error` accordingly. ## How was this change tested? - Ran all tests - Ran all-in-one and checked if traces are appearing ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Arunvel Sriram <arunvelsriram@gmail.com> Signed-off-by: Saumya Shah <saumyabshah90@gmail.com>
Saumya40-codes
pushed a commit
to Saumya40-codes/jaeger
that referenced
this pull request
Oct 14, 2024
…in case of db issues (jaegertracing#6061) ## Which problem is this PR solving? - Resolves jaegertracing#432 - jaegertracing#432 (comment) ## Description of the changes The current [operation names table check logic](https://github.com/jaegertracing/jaeger/blob/main/plugin/storage/cassandra/spanstore/operation_names.go#L97-L99) creates `OperationNamesStorage` instance pointing to old schema table in case of issues with Cassandra. - Check for the existence of old schema table before fallback - Make `OperationNamesStorage` constructor `NewOperationsStorage` to return `error` if both old and new tables doesn't exist or both of their existence cannot be checked. Since there was no `error` returned from `NewOperationsStorage` earlier had to update the dependencies and handle the `error` accordingly. ## How was this change tested? - Ran all tests - Ran all-in-one and checked if traces are appearing ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Arunvel Sriram <arunvelsriram@gmail.com> Signed-off-by: Saumya Shah <saumyabshah90@gmail.com>
chahatsagarmain
pushed a commit
to chahatsagarmain/jaeger
that referenced
this pull request
Oct 23, 2024
…in case of db issues (jaegertracing#6061) ## Which problem is this PR solving? - Resolves jaegertracing#432 - jaegertracing#432 (comment) ## Description of the changes The current [operation names table check logic](https://github.com/jaegertracing/jaeger/blob/main/plugin/storage/cassandra/spanstore/operation_names.go#L97-L99) creates `OperationNamesStorage` instance pointing to old schema table in case of issues with Cassandra. - Check for the existence of old schema table before fallback - Make `OperationNamesStorage` constructor `NewOperationsStorage` to return `error` if both old and new tables doesn't exist or both of their existence cannot be checked. Since there was no `error` returned from `NewOperationsStorage` earlier had to update the dependencies and handle the `error` accordingly. ## How was this change tested? - Ran all tests - Ran all-in-one and checked if traces are appearing ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Arunvel Sriram <arunvelsriram@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
The current operation names table check logic creates
OperationNamesStorageinstance pointing to old schema table in case of issues with Cassandra.OperationNamesStorageconstructorNewOperationsStorageto returnerrorif both old and new tables doesn't exist or both of their existence cannot be checked. Since there was noerrorreturned fromNewOperationsStorageearlier had to update the dependencies and handle theerroraccordingly.How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test