-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][spm]: Change default metrics namespace to match new default in spanmetricsconnector #6007
Conversation
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
7d06308
to
6e18151
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6007 +/- ##
==========================================
+ Coverage 96.78% 96.79% +0.01%
==========================================
Files 348 348
Lines 16559 16559
==========================================
+ Hits 16027 16029 +2
+ Misses 343 342 -1
+ Partials 189 188 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
plugin/metrics/prometheus/options.go
Outdated
@@ -33,7 +33,7 @@ const ( | |||
defaultTokenFilePath = "" | |||
|
|||
defaultSupportSpanmetricsConnector = true | |||
defaultMetricNamespace = "" | |||
defaultMetricNamespace = "traces_span_metrics" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yurishkuro setting this default here seems to take care of the v2 test but the v1 test is still getting an empty response. do you have any idea why that could be? both v1 and v2 read this config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was actually not related to the changes in this PR and was failing due to missing http receiver endpoint in the otel collector config but wasn't failing before because the version was pinned to 0.89.0
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for digging into this one! 🥳
Which problem is this PR solving?
Description of the changes
traces_span_metrics
the new namespace default.traces_span_metrics
. This matches the new default namespace in thespanmetricsconnector
which was changed inv0.109.0
(see f7o/opentelemetry-collector-contrib@371bc59)How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test