Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger-v2] Refactor Configuration For Query Service #5998

Merged
merged 21 commits into from
Sep 25, 2024

Conversation

mahadzaryab1
Copy link
Collaborator

@mahadzaryab1 mahadzaryab1 commented Sep 18, 2024

Which problem is this PR solving?

Description of the changes

  • Reworked the configuration for jaeger-query to have more logical groupings.
  • Migration document

How was this change tested?

  • CI

Checklist

Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1 mahadzaryab1 changed the title [jaeger-v2] Refactor Configurations For Query Service [jaeger-v2] Refactor Configuration For Query Service Sep 18, 2024
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.79%. Comparing base (7c6ed87) to head (e53c75e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5998      +/-   ##
==========================================
- Coverage   96.79%   96.79%   -0.01%     
==========================================
  Files         349      349              
  Lines       16582    16581       -1     
==========================================
- Hits        16050    16049       -1     
  Misses        343      343              
  Partials      189      189              
Flag Coverage Δ
badger_v1 8.00% <ø> (ø)
badger_v2 1.82% <ø> (ø)
cassandra-4.x-v1 16.56% <ø> (ø)
cassandra-4.x-v2 1.75% <ø> (ø)
cassandra-5.x-v1 16.56% <ø> (ø)
cassandra-5.x-v2 1.75% <ø> (ø)
elasticsearch-6.x-v1 18.73% <ø> (ø)
elasticsearch-7.x-v1 18.79% <ø> (+0.01%) ⬆️
elasticsearch-8.x-v1 18.98% <ø> (ø)
elasticsearch-8.x-v2 1.81% <ø> (ø)
grpc_v1 9.53% <ø> (ø)
grpc_v2 7.13% <ø> (ø)
kafka-v1 9.71% <ø> (ø)
kafka-v2 1.82% <ø> (ø)
memory_v2 1.82% <ø> (+0.01%) ⬆️
opensearch-1.x-v1 18.83% <ø> (-0.02%) ⬇️
opensearch-2.x-v1 18.84% <ø> (+0.01%) ⬆️
opensearch-2.x-v2 1.82% <ø> (+0.01%) ⬆️
tailsampling-processor 0.46% <ø> (ø)
unittests 95.27% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1 mahadzaryab1 marked this pull request as ready for review September 19, 2024 03:53
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner September 19, 2024 03:53
cmd/query/app/flags.go Show resolved Hide resolved
cmd/query/app/flags.go Show resolved Hide resolved
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple cleanups, otherwise lgtm

cmd/query/app/flags_test.go Show resolved Hide resolved
cmd/query/app/static_handler.go Outdated Show resolved Hide resolved
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@yurishkuro yurishkuro merged commit d7f01d1 into jaegertracing:main Sep 25, 2024
49 checks passed
@mahadzaryab1 mahadzaryab1 deleted the query-service-v2 branch September 28, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:exprimental Change to an experimental part of the code v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants