Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex for publishing v2 image #5988

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

  • Release attempt did not publish v2 image
[[ v2.0.0-rc1 =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]
+ echo 'skipping docker images upload, because not on tagged release or main branch'

Description of the changes

  • Fix the regex to include -rc suffix

How was this change tested?

  • CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Sep 15, 2024
@yurishkuro yurishkuro requested a review from a team as a code owner September 15, 2024 01:36
@dosubot dosubot bot added docker Pull requests that update Docker code v2 labels Sep 15, 2024
Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.81%. Comparing base (e047f20) to head (8ced72e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5988   +/-   ##
=======================================
  Coverage   96.81%   96.81%           
=======================================
  Files         345      345           
  Lines       16523    16523           
=======================================
  Hits        15996    15996           
  Misses        340      340           
  Partials      187      187           
Flag Coverage Δ
badger_v1 8.02% <ø> (ø)
badger_v2 1.82% <ø> (ø)
cassandra-4.x-v1 16.61% <ø> (ø)
cassandra-4.x-v2 1.75% <ø> (ø)
cassandra-5.x-v1 16.61% <ø> (ø)
cassandra-5.x-v2 1.75% <ø> (ø)
elasticsearch-6.x-v1 18.77% <ø> (-0.02%) ⬇️
elasticsearch-7.x-v1 18.84% <ø> (ø)
elasticsearch-8.x-v1 19.04% <ø> (ø)
elasticsearch-8.x-v2 1.81% <ø> (-0.02%) ⬇️
grpc_v1 9.52% <ø> (+0.01%) ⬆️
grpc_v2 7.15% <ø> (ø)
kafka-v1 9.74% <ø> (ø)
kafka-v2 1.82% <ø> (ø)
memory_v2 1.81% <ø> (ø)
opensearch-1.x-v1 18.89% <ø> (ø)
opensearch-2.x-v1 18.88% <ø> (-0.02%) ⬇️
opensearch-2.x-v2 1.81% <ø> (ø)
tailsampling-processor 0.46% <ø> (ø)
unittests 95.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 0824fc2 into jaegertracing:main Sep 15, 2024
52 checks passed
@yurishkuro yurishkuro deleted the fix-release-v2 branch September 15, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing docker Pull requests that update Docker code v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant