Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OTLP JSON support for Kafka e2e Integration tests #5935

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

joeyyy09
Copy link
Member

@joeyyy09 joeyyy09 commented Sep 4, 2024

Which problem is this PR solving?

  • This PR addresses the issue of verifying Kafka e2e integration tests for otlp_json formats.

Description of the changes

  • Verified if the Kafka e2e integration tests run for otlp_json formats.
  • Used a fork of mine (github.com/joeyyy09/opentelemetry-collector-contrib) to incorporate necessary changes and verify the process.

How was this change tested?

  • Ran the Kafka e2e integration tests locally using the modified configuration.

Checklist

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (9eaa882) to head (eea655a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5935      +/-   ##
==========================================
- Coverage   96.49%   96.48%   -0.02%     
==========================================
  Files         352      352              
  Lines       19973    19973              
==========================================
- Hits        19273    19270       -3     
- Misses        518      520       +2     
- Partials      182      183       +1     
Flag Coverage Δ
badger_v1 8.42% <ø> (ø)
badger_v2 1.70% <ø> (ø)
cassandra-4.x-v1 14.57% <ø> (ø)
cassandra-4.x-v2 1.64% <ø> (ø)
cassandra-5.x-v1 14.57% <ø> (ø)
cassandra-5.x-v2 1.64% <ø> (ø)
elasticsearch-6.x-v1 18.72% <ø> (-0.02%) ⬇️
elasticsearch-7.x-v1 18.80% <ø> (ø)
elasticsearch-8.x-v1 18.97% <ø> (ø)
elasticsearch-8.x-v2 1.69% <ø> (ø)
grpc_v1 8.78% <ø> (+0.01%) ⬆️
grpc_v2 6.72% <ø> (+0.01%) ⬆️
kafka-v1 8.99% <ø> (ø)
kafka-v2 1.70% <ø> (ø)
memory_v2 1.69% <ø> (-0.02%) ⬇️
opensearch-1.x-v1 18.86% <ø> (ø)
opensearch-2.x-v1 18.85% <ø> (ø)
opensearch-2.x-v2 1.70% <ø> (+0.01%) ⬆️
tailsampling-processor 0.48% <ø> (ø)
unittests 95.39% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro
Copy link
Member

please link to OTEL PR

@yurishkuro yurishkuro added the changelog:exprimental Change to an experimental part of the code label Sep 9, 2024
Signed-off-by: joeyyy09 <menteharshith@gmail.com>
@joeyyy09 joeyyy09 marked this pull request as ready for review September 16, 2024 09:47
@joeyyy09 joeyyy09 requested a review from a team as a code owner September 16, 2024 09:47
@joeyyy09
Copy link
Member Author

will be good to go after the next release of otel-collector-contrib

@yurishkuro
Copy link
Member

otel-collector-contrib was upgraded, trying this fix again

@yurishkuro yurishkuro enabled auto-merge (squash) October 23, 2024 17:12
@joeyyy09
Copy link
Member Author

joeyyy09 commented Oct 23, 2024

otel-collector-contrib was upgraded, trying this fix again

That's great! I think now this is ready to go! Thanks! 🚀

@yurishkuro yurishkuro merged commit fcb6ba2 into jaegertracing:main Oct 23, 2024
49 checks passed
@yurishkuro
Copy link
Member

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:exprimental Change to an experimental part of the code storage/kafka
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants