-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore "operation" name in the metrics response #5673
Conversation
Signed-off-by: Yuri Shkuro <github@ysh.us>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5673 +/- ##
==========================================
+ Coverage 92.35% 96.39% +4.03%
==========================================
Files 163 329 +166
Lines 8413 16056 +7643
==========================================
+ Hits 7770 15477 +7707
+ Misses 523 403 -120
- Partials 120 176 +56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
## Which problem is this PR solving? - Resolves #5672 - Due to oversight, a bug was introduced in #5539 which changed the attribute name expected by the UI from `operation` to `span_name` ## Description of the changes - Revert those changes ## How was this change tested? `(cd docker-compose/monitor/ && make build dev)` <img width="1910" alt="image" src="https://github.com/jaegertracing/jaeger/assets/3523016/79400073-75f1-4db5-8bef-9a4c439d2852"> ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: Yuri Shkuro <github@ysh.us>
Which problem is this PR solving?
operation
tospan_name
Description of the changes
How was this change tested?
(cd docker-compose/monitor/ && make build dev)
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test