-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[query] Avoid errors when closing shared listener #5559
Merged
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
65f6cba
Fix flaky TestServerSinglePort by adding dynamic port assignment and …
vermaaatul07 bc68cba
Refine logging and error handling in server operations
vermaaatul07 d5fb088
Improve error handling and logging in server start and close methods
vermaaatul07 f8e7c45
Add detailed logging and error handling as per maintainer's feedback
vermaaatul07 75351a8
Implement enhanced logging and error handling for TestServerSinglePort
vermaaatul07 3d35a4b
Improve error handling and add logging for Close method
vermaaatul07 150a04c
Merge branch 'main' into fix-flaky-test
yurishkuro bafa622
clean-up
yurishkuro 8be6e17
clean-up
yurishkuro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should add this option to the logger in the test:
that way it prints the source line.
I changed the timeout to 2s and look what the logs say:
note that after
Stopping gRPC server
we're seeingHTTP server stopped
, even beforeClosing HTTP server
. When I add a log line for CMUX server goroutine, it also logs that CMUX server is stopped before we come to trying to stop HTTP. So it seems when we're running on a single port it's simply sufficient to close gRPC server, which closes the underlying listenter, and all other servers exit automatically (we do already catchErrServerClosed
errors and don't log them).