Enable Lint Rules: confusing-results & receiver-naming

[FlamingSaint]

Which problem is this PR solving?

• Partial Fix for Enable more revive linter rules #5506

Description of the changes

• Enabled confusing-results & receiver-naming in revive linter
• Used named outputs when datatype of outputs are same
• Made changes to maintain the same receiver name

How was this change tested?

• make lint make test

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: yarn lint and yarn test

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (b295383) to head (5c8f299).

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #5524       +/-   ##
===========================================
+ Coverage   54.24%   96.19%   +41.94%     
===========================================
  Files         161      327      +166     
  Lines        8369    16013     +7644     
===========================================
+ Hits         4540    15403    +10863     
+ Misses       3383      435     -2948     
+ Partials      446      175      -271     

Flag	Coverage Δ
badger_v1	8.05% <0.00%> (ø)
badger_v2	1.93% <0.00%> (ø)
cassandra-3.x-v1	16.44% <40.00%> (ø)
cassandra-3.x-v2	1.85% <0.00%> (ø)
cassandra-4.x-v1	16.44% <40.00%> (ø)
cassandra-4.x-v2	1.85% <0.00%> (ø)
elasticsearch-7-v1	18.88% <13.33%> (-0.02%)	⬇️
elasticsearch-8-v1	19.08% <13.33%> (ø)
elasticsearch-8-v2	19.08% <13.33%> (+0.01%)	⬆️
grpc_v1	9.48% <3.33%> (ø)
grpc_v2	7.53% <3.33%> (ø)
kafka	9.78% <0.00%> (ø)
opensearch-1-v1	18.92% <13.33%> (-0.02%)	⬇️
opensearch-2-v1	18.92% <13.33%> (-0.02%)	⬇️
opensearch-2-v2	18.92% <13.33%> (ø)
unittests	93.88% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yurishkuro]

hmm, DCO check is stuck. I see you changed your name/email in git, did you also change it the same way in your GitHub profile?

[FlamingSaint]

hmm, DCO check is stuck. I see you changed your name/email in git, did you also change it the same way in your GitHub profile?

I didn't change my name/email in git