-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove args and depict the image in From directive #5465
Conversation
remove root_image and cert_image and all the references Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
add Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
fix alpine version to 3.19.0 Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
add Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
add Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
fixed lint errors Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
fix Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
Remove args and depict the image in From directive Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5465 +/- ##
===========================================
- Coverage 95.49% 37.94% -57.55%
===========================================
Files 331 160 -171
Lines 16121 8351 -7770
===========================================
- Hits 15395 3169 -12226
- Misses 554 4877 +4323
- Partials 172 305 +133
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about go-alpine?
yes, didnt see |
fix Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
Which problem is this PR solving?
Fixes: #5450
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test