Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove args and depict the image in From directive #5465

Merged
merged 10 commits into from
May 20, 2024

Conversation

prakrit55
Copy link
Contributor

Which problem is this PR solving?

Fixes: #5450

Checklist

prakrit55 added 9 commits May 16, 2024 00:06
remove root_image and cert_image and all the references

Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
add

Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
fix alpine version to 3.19.0

Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
add

Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
add

Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
fixed lint errors

Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
fix

Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
Remove args and depict the image in From directive

Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
@prakrit55 prakrit55 requested a review from a team as a code owner May 20, 2024 05:41
@prakrit55 prakrit55 requested a review from joe-elliott May 20, 2024 05:41
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.94%. Comparing base (3dbd02b) to head (217bb7f).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5465       +/-   ##
===========================================
- Coverage   95.49%   37.94%   -57.55%     
===========================================
  Files         331      160      -171     
  Lines       16121     8351     -7770     
===========================================
- Hits        15395     3169    -12226     
- Misses        554     4877     +4323     
- Partials      172      305      +133     
Flag Coverage Δ
badger_v1 8.07% <ø> (ø)
badger_v2 1.94% <ø> (ø)
cassandra-3.x-v1 16.47% <ø> (ø)
cassandra-3.x-v2 1.86% <ø> (ø)
cassandra-4.x-v1 16.47% <ø> (ø)
cassandra-4.x-v2 1.86% <ø> (ø)
elasticsearch-7.x 1.78% <ø> (ø)
elasticsearch-8.x 1.78% <ø> (ø)
grpc_v1 9.24% <ø> (ø)
grpc_v2 7.60% <ø> (+0.01%) ⬆️
kafka 9.80% <ø> (ø)
opensearch-1.x 1.78% <ø> (ø)
opensearch-2.x 1.78% <ø> (+0.01%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label May 20, 2024
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about go-alpine?

@prakrit55
Copy link
Contributor Author

what about go-alpine?

yes, didnt see

fix

Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@yurishkuro yurishkuro merged commit 2eee293 into jaegertracing:main May 20, 2024
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: can we upgrade the base image of jaeger-query?
2 participants