Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kafka-consumer] Add support for setting fetch message max bytes #5283

Merged
merged 1 commit into from
Mar 19, 2024
Merged

[kafka-consumer] Add support for setting fetch message max bytes #5283

merged 1 commit into from
Mar 19, 2024

Conversation

sappusaketh
Copy link
Contributor

@sappusaketh sappusaketh commented Mar 18, 2024

Which problem is this PR solving?

  • PR [kafka-producer] Support setting max message size #5263 added support for setting max message size a producer can send that solved the issue on collector end now we are seeing our consumer getting stuck consuming messages larger that 1MB(default fetch max message bytes) so adding an option to set this value via flags

Description of the changes

  • adding an option to set fetch max message bytes value via flags

How was this change tested?

  • Tested against our dev jaeger where we have spans larger than 1 MB

Checklist

Signed-off-by: Saketh kappala <43525626+sappusaketh@users.noreply.github.com>
@sappusaketh sappusaketh requested a review from a team as a code owner March 18, 2024 15:30
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.06%. Comparing base (b82c806) to head (21782c4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5283      +/-   ##
==========================================
- Coverage   95.07%   95.06%   -0.01%     
==========================================
  Files         340      340              
  Lines       16597    16604       +7     
==========================================
+ Hits        15780    15785       +5     
- Misses        628      630       +2     
  Partials      189      189              
Flag Coverage Δ
badger 13.26% <0.00%> (-0.02%) ⬇️
cassandra-3.x 26.44% <0.00%> (-0.04%) ⬇️
cassandra-4.x 26.44% <0.00%> (-0.04%) ⬇️
elasticsearch-5.x 21.70% <0.00%> (-0.03%) ⬇️
elasticsearch-6.x 21.70% <0.00%> (-0.03%) ⬇️
elasticsearch-7.x 21.78% <0.00%> (-0.03%) ⬇️
elasticsearch-8.x 21.85% <0.00%> (-0.03%) ⬇️
grpc 10.86% <0.00%> (+0.01%) ⬆️
kafka 14.73% <100.00%> (+0.10%) ⬆️
opensearch-1.x 21.77% <0.00%> (-0.05%) ⬇️
opensearch-2.x 21.77% <0.00%> (-0.05%) ⬇️
unittests 92.29% <71.42%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro changed the title [kafka-consumer] add support for setting fetch message max bytes [kafka-consumer] Add support for setting fetch message max bytes Mar 19, 2024
@yurishkuro yurishkuro merged commit 55ceba9 into jaegertracing:main Mar 19, 2024
37 of 38 checks passed
@yurishkuro
Copy link
Member

thanks

@sappusaketh sappusaketh deleted the kafka-consumer-fetch-max-bytes branch April 19, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants