Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test summary reports #5126

Merged
merged 2 commits into from
Jan 21, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions .github/workflows/ci-unit-tests-go-tip.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,36 +30,5 @@ jobs:
- name: Run unit tests
run: make test-ci

- name: Prepare unit tests report
if: always()
run: make test-report

- name: Publish Unit Test Summary 📑
uses: EnricoMi/publish-unit-test-result-action@v2
if: always()
with:
check_name: Go Tip Unit Tests Summary
junit_files: junit-report.xml
# This workflow isn't run during Pull Requests, so check run and PR comment summaries are not needed.
check_run: false
comment_mode: off

- name: Upload Test Results
if: always()
uses: actions/upload-artifact@v4
with:
name: Test Results
path: junit-report.xml

- name: Lint
run: echo skip linting on Go tip

event-file:
name: "Event File"
runs-on: ubuntu-latest
steps:
- name: Upload
uses: actions/upload-artifact@v4
with:
name: Event File
path: ${{ github.event_path }}
42 changes: 0 additions & 42 deletions .github/workflows/ci-unit-tests-report.yml

This file was deleted.

31 changes: 0 additions & 31 deletions .github/workflows/ci-unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,27 +39,6 @@ jobs:
- name: Run unit tests
run: make test-ci

- name: Prepare unit tests report
if: always()
run: make test-report

- name: Publish Unit Test Summary 📑
uses: EnricoMi/publish-unit-test-result-action@v2
if: always()
with:
check_name: Unit Tests Summary
junit_files: junit-report.xml
# PR comments and check run will be performed by the "Unit Test Results" workflow.
comment_mode: off
check_run: false

- name: Upload Test Results
if: always()
uses: actions/upload-artifact@v4
with:
name: Test Results
path: junit-report.xml

- name: Setup CODECOV_TOKEN
uses: ./.github/actions/setup-codecov

Expand All @@ -71,13 +50,3 @@ jobs:
flags: unittests
fail_ci_if_error: true
token: ${{ env.CODECOV_TOKEN }}

event-file:
name: "Event File"
runs-on: ubuntu-latest
steps:
- name: Upload
uses: actions/upload-artifact@v4
with:
name: Event File
path: ${{ github.event_path }}
5 changes: 0 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,6 @@ draft-release:
install-test-tools:
$(GO) install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.55.2
$(GO) install mvdan.cc/gofumpt@latest
$(GO) install github.com/jstemmer/go-junit-report/v2@latest

.PHONY: install-build-tools
install-build-tools:
Expand All @@ -455,10 +454,6 @@ install-ci: install-test-tools install-build-tools
test-ci: GOTEST := $(GOTEST_QUIET) -json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, good catch; thanks! Removed -json flag in: 5675e49

test-ci: build-examples cover

.PHONY: test-report
test-report:
cat test-results.json | go-junit-report -parser gojson > junit-report.xml

.PHONY: init-submodules
init-submodules:
git submodule update --init --recursive
Expand Down