Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate Thrift types and enable Thrift check #5039

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

  • Thrift types were not re-synced after upgrading to the latest Thrift compiler

Description of the changes

  • Regenerate files - all changes seem to be formatting related
  • Enable Thrift generation check in CI to prevent this in the future

How was this change tested?

  • CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner December 25, 2023 23:35
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Dec 25, 2023
Copy link

codecov bot commented Dec 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a798e25) 52.59% compared to head (f32ee61) 95.58%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5039       +/-   ##
===========================================
+ Coverage   52.59%   95.58%   +42.98%     
===========================================
  Files         145      319      +174     
  Lines        8599    18794    +10195     
===========================================
+ Hits         4523    17965    +13442     
+ Misses       3728      665     -3063     
+ Partials      348      164      -184     
Flag Coverage Δ
cassandra-3.x 25.61% <ø> (ø)
cassandra-4.x 25.61% <ø> (ø)
elasticsearch-5.x 19.88% <ø> (ø)
elasticsearch-6.x 19.88% <ø> (ø)
elasticsearch-7.x 20.00% <ø> (-0.02%) ⬇️
elasticsearch-8.x 20.09% <ø> (-0.02%) ⬇️
grpc-badger 19.51% <ø> (+0.01%) ⬆️
kafka 14.10% <ø> (ø)
opensearch-1.x 20.02% <ø> (ø)
opensearch-2.x 20.02% <ø> (ø)
unittests 93.33% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro requested review from albertteoh and removed request for jkowall December 26, 2023 03:08
@yurishkuro yurishkuro merged commit c3fa953 into jaegertracing:main Dec 26, 2023
37 of 38 checks passed
@yurishkuro yurishkuro deleted the refresh-thrift branch December 26, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants