Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split unit-test workflow into tests and lint #4933

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Split unit-test workflow into tests and lint #4933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
819d2c9
Splited unit-test workflow into tests and lint
MeenuyD Nov 6, 2023
a29e8e2
Corrected code
MeenuyD Nov 6, 2023
350d2f3
Update .github/workflows/ci-lint-checks.yaml
MeenuyD Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions .github/workflows/ci-lint-checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
name: Lint Checks

on:
push:
branches: [main]

pull_request:
branches: [main]

concurrency:
group: ${{ github.workflow }}-${{ (github.event.pull_request && github.event.pull_request.number) || github.ref || github.run_id }}
cancel-in-progress: true

# See https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions
permissions: # added using https://github.com/step-security/secure-workflows
contents: read

jobs:
lint:
runs-on: ubuntu-latest
steps:
- name: Harden Runner
uses: step-security/harden-runner@1b05615854632b887b69ae1be8cbefe72d3ae423
with:
egress-policy: audit # TODO: change to 'egress-policy: block' after a couple of runs

- uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608
MeenuyD marked this conversation as resolved.
Show resolved Hide resolved

- uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe
with:
go-version: 1.21.x

- name: Install tools
run: make install-test-tools

- name: Lint
run: make lint
6 changes: 0 additions & 6 deletions .github/workflows/ci-unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@ jobs:
with:
go-version: 1.21.x

- name: Install tools
run: make install-test-tools

- name: Run unit tests
run: make test-ci

Expand All @@ -50,6 +47,3 @@ jobs:
flags: unittests
fail_ci_if_error: true
token: ${{ env.CODECOV_TOKEN }}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also remove make install-test-tools above

- name: Lint
run: make lint
Loading