Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Set default to fix 'unbound variable' error on main #4916

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Nov 3, 2023

Which problem is this PR solving?

Build failed on main:

scripts/build-all-in-one-image.sh: line 5: $1: unbound variable

Description of the changes

  • Use default value for $1 var

How was this change tested?

$ bash scripts/build-all-in-one-image.sh
+ arg1=not-pr
+ [[ not-pr == \p\r\-\o\n\l\y ]]
+ is_pull_request=false
+ BINARY=all-in-one
++ go env GOARCH
+ GOARCH=arm64
+ repo=jaegertracing/all-in-one
++ cat jaeger-ui/.nvmrc
+ expected_version=v18
++ node --version
scripts/build-all-in-one-image.sh: line 23: node: command not found
+ version=

fails much later (as expected)

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Nov 3, 2023
@yurishkuro yurishkuro requested a review from a team as a code owner November 3, 2023 12:33
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@yurishkuro yurishkuro merged commit 5e91855 into jaegertracing:main Nov 3, 2023
34 checks passed
@yurishkuro yurishkuro deleted the fix-script branch November 3, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant