-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reload interval to OTel server certificates #4898
Conversation
Signed-off-by: James Ryans <james.ryans2012@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
pkg/config/tlscfg/flags.go
Outdated
@@ -66,6 +67,7 @@ func (c ServerFlagsConfig) AddFlags(flags *flag.FlagSet) { | |||
flags.String(c.Prefix+tlsCipherSuites, "", "Comma-separated list of cipher suites for the server, values are from tls package constants (https://golang.org/pkg/crypto/tls/#pkg-constants).") | |||
flags.String(c.Prefix+tlsMinVersion, "", "Minimum TLS version supported (Possible values: 1.0, 1.1, 1.2, 1.3)") | |||
flags.String(c.Prefix+tlsMaxVersion, "", "Maximum TLS version supported (Possible values: 1.0, 1.1, 1.2, 1.3)") | |||
flags.Duration(c.Prefix+tlsReloadInterval, 0, "The duration after which the certificate will be reloaded (0s means will not be reloaded)") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add a capability, e.g. ServerFlagsConfig.EnableCertReloadInterval
, to enable/disable this option. Otherwise it will show up in all uses of the tlscfg
, including the many places which do NOT implement the reload functionality today (but may implement file watching).
…d otlp.grpc.tls flags Signed-off-by: James Ryans <james.ryans2012@gmail.com>
Signed-off-by: James Ryans <james.ryans2012@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: James Ryans <james.ryans2012@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Which problem is this PR solving?
Description of the changes
otlp.http.tls.reload-interval
andotlp.grpc.tls.reload-interval
flags (0s means disabled)How was this change tested?
*.tls.reload-interval
flag unit tests toflags.go
andotel_receiver.go
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test