Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Query API v3 to official OpenTelemetry format #4742

Merged
merged 8 commits into from
Sep 10, 2023
Merged

Upgrade Query API v3 to official OpenTelemetry format #4742

merged 8 commits into from
Sep 10, 2023

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Sep 10, 2023 •
edited
Loading

Which problem is this PR solving?

Description of the changes

  • pull the latest version of jaeger-idl that uses OTLP v1
  • regenerate protobuf types
  • remove explicit translation with github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/jaeger
  • fix tests. Unfortunately, the actual translation returns error that cannot be reproduced / tested, thus coverage declined a bit

How was this change tested?

  • CI only

@yurishkuro
Upgrade IDL
2f63ac8 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
errors
0cc7046 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
example
b876080 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
fix
b54842c 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
idl
8fd1759 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner September 10, 2023 03:46
@yurishkuro yurishkuro requested a review from jkowall September 10, 2023 03:46
@yurishkuro
remove
51e6bf0 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link

codecov bot commented Sep 10, 2023 •
edited
Loading

Codecov Report

Patch coverage is 63.63% of modified lines.

Files Changed Coverage
cmd/query/app/apiv3/otlp_translator.go 61.53%
cmd/query/app/apiv3/grpc_handler.go 66.66%

📢 Thoughts on this report? Let us know!.

@yurishkuro
fix
38cd0cc 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
gmt
c8c84aa 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro merged commit 8f680cc into jaegertracing:main Sep 10, 2023
@yurishkuro yurishkuro deleted the fix-4648 branch September 10, 2023 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkowall jkowall Awaiting requested review from jkowall jkowall is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Query API v3 to official OpenTelemetry format
1 participant
@yurishkuro