Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Disable tracing of OTLP Receiver #4662

Merged

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • use NoOp tracer provider in the OTLP receiver configuration

How was this change tested?

  • ran the UI, reloaded page many times, this endpoint no longer shows up

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro marked this pull request as ready for review August 14, 2023 20:29
@yurishkuro yurishkuro requested a review from a team as a code owner August 14, 2023 20:29
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (eb31736) 97.02% compared to head (a171146) 97.06%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4662      +/-   ##
==========================================
+ Coverage   97.02%   97.06%   +0.03%     
==========================================
  Files         301      301              
  Lines       17878    17878              
==========================================
+ Hits        17346    17353       +7     
+ Misses        426      421       -5     
+ Partials      106      104       -2     
Flag Coverage Δ
unittests 97.06% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cmd/collector/app/handler/otlp_receiver.go 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertteoh
Copy link
Contributor

Thanks!

@yurishkuro yurishkuro merged commit 54ec466 into jaegertracing:main Aug 14, 2023
31 checks passed
@yurishkuro yurishkuro deleted the disable-tracing-for-otlp-receiver branch August 14, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: recursive tracing in all-in-one
2 participants