Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tracegen] Allow to control cardinality of attribute keys #4634

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

yurishkuro
Copy link
Member

Description of the changes

  • Add flag to control cardinality of attribute keys
  • Use prime numbers for default number of attributes and keys

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner August 7, 2023 16:44
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (369219c) 97.07% compared to head (f2f34eb) 97.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4634      +/-   ##
==========================================
+ Coverage   97.07%   97.09%   +0.01%     
==========================================
  Files         301      301              
  Lines       17878    17878              
==========================================
+ Hits        17355    17358       +3     
+ Misses        419      417       -2     
+ Partials      104      103       -1     
Flag Coverage Δ
unittests 97.09% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 41616d9 into jaegertracing:main Aug 7, 2023
31 checks passed
@yurishkuro yurishkuro deleted the tracegen-attr-keys branch August 7, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant