Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zipkin] Replace OT constants with OTEL #4625

Merged

Conversation

afzal442
Copy link
Contributor

@afzal442 afzal442 commented Aug 4, 2023

Which problem is this PR solving?

Short description of the changes

  • Replace OT const with otel trace spans const i.e. ext.SpanKind.. with trace.SpanKind..

@afzal442 afzal442 requested a review from a team as a code owner August 4, 2023 19:02
@afzal442 afzal442 requested a review from jkowall August 4, 2023 19:02
yurishkuro
yurishkuro previously approved these changes Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% ⚠️

Comparison is base (0d06c56) 97.06% compared to head (a753742) 97.05%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4625      +/-   ##
==========================================
- Coverage   97.06%   97.05%   -0.02%     
==========================================
  Files         301      301              
  Lines       17877    17878       +1     
==========================================
- Hits        17353    17351       -2     
- Misses        420      422       +2     
- Partials      104      105       +1     
Flag Coverage Δ
unittests 97.05% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
model/converter/thrift/zipkin/to_domain.go 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Afzal <94980910+afzalbin64@users.noreply.github.com>
@yurishkuro yurishkuro changed the title [WIP] Replace OT const wth OTEL trace.span for zipkin comp [zipkin] Replace OT constants with OTEL Aug 7, 2023
@yurishkuro yurishkuro merged commit 078051c into jaegertracing:main Aug 7, 2023
31 checks passed
@afzal442 afzal442 deleted the replace-zipkin-to_domain-ot-const branch August 7, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants