[hotrod] Return trace ID via traceresponse header #4584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4584 +/- ##
=======================================
Coverage 97.05% 97.05%
=======================================
Files 301 301
Lines 17839 17839
=======================================
Hits 17313 17313
Misses 422 422
Partials 104 104
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Since the HotROD UI does not start traces, it can only search for a trace corresponding to a particular request by some span tags. This makes the experience of opening a trace a big clunky as we first see the search page with one trace, and then have to click on the trace again.
Related to #3380
Short description of the changes
Change the HTTP instrumentation to always generate a
traceresponseheader per the current W3C draft. Then parse the trace ID from that header in the UI and generate a hyperlink to open the trace view directly, bypassing the search.