Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci]: skipping debug builds when not making a release #4496

Merged
merged 4 commits into from
Jun 4, 2023
Merged

[ci]: skipping debug builds when not making a release #4496

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23b9a21
fix(skip debug): skipping debug builds when not a release
psk001 Jun 2, 2023
1985bb8
feat(non release build): skip building debug images in non-release build
psk001 Jun 4, 2023
ece620b
feat(non release build): skip building debug images in non-release build
psk001 Jun 4, 2023
82f0a7c
Merge branch 'main' into issue-4471
yurishkuro Jun 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci-all-in-one-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,4 @@ jobs:
env:
DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
QUAY_TOKEN: ${{ secrets.QUAY_TOKEN }}
SKIP_DEBUG: ${{inputs.SKIP_DEBUG}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't run actions manually. The main release is done by .github/workflows/ci-release.yml, so there it should be enabling debug builds, and here they should be explicitly disabled.

20 changes: 13 additions & 7 deletions scripts/build-all-in-one-image.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ GOARCH=${GOARCH:-$(go env GOARCH)}
expected_version="v16"
version=$(node --version)
major_version=${version%.*.*}
SKIP_DEBUG=$SKIP_DEBUG

if [ "$major_version" = "$expected_version" ] ; then
echo "Node version is as expected: $version"
else
Expand Down Expand Up @@ -46,10 +48,14 @@ run_integration_test localhost:5000/$repo
bash scripts/build-upload-a-docker-image.sh -b -c all-in-one -d cmd/all-in-one -p "${platforms}" -t release


make build-all-in-one-debug GOOS=linux GOARCH=$GOARCH
repo=${repo}-debug
#build all-in-one-debug image locally for integration test
bash scripts/build-upload-a-docker-image.sh -l -b -c all-in-one-debug -d cmd/all-in-one -t debug
run_integration_test localhost:5000/$repo
#build all-in-one-debug image and upload to dockerhub/quay.io
bash scripts/build-upload-a-docker-image.sh -b -c all-in-one-debug -d cmd/all-in-one -t debug
if [ "$SKIP_DEBUG" = true ] ; then
make build-all-in-one-debug GOOS=linux GOARCH=$GOARCH
repo=${repo}-debug
#build all-in-one-debug image locally for integration test
bash scripts/build-upload-a-docker-image.sh -l -b -c all-in-one-debug -d cmd/all-in-one -t debug
run_integration_test localhost:5000/$repo
#build all-in-one-debug image and upload to dockerhub/quay.io
bash scripts/build-upload-a-docker-image.sh -b -c all-in-one-debug -d cmd/all-in-one -t debug
else
echo "Skipping debug commands"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this should be in the then part

fi