Fix flaky test - TestSpanProcessorWithOnDroppedSpanOption #4451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Xu <chen.x@uber.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4451 +/- ##
==========================================
+ Coverage 97.07% 97.09% +0.01%
==========================================
Files 300 300
Lines 17728 17728
==========================================
+ Hits 17210 17213 +3
+ Misses 416 414 -2
+ Partials 102 101 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
albertteoh
reviewed
May 12, 2023
| @@ -679,5 +680,5 @@ func TestSpanProcessorWithOnDroppedSpanOption(t *testing.T) { | |||
| }, processor.SpansOptions{SpanFormat: processor.JaegerSpanFormat}) | |||
|
|
|||
| assert.NoError(t, err) | |||
| assert.Equal(t, []string{"op2", "op3"}, droppedOperations) | |||
There was a problem hiding this comment.
I suggest you keep the original test but add an assert.Eventually to ensure the right state, like so:
assert.NoError(t, err)
assert.Eventually(t, func() bool {
return len(droppedOperations) == 2
}, 5*time.Second, 10*time.Millisecond)
assert.Equal(t, []string{"op2", "op3"}, droppedOperations)
|
closing to minimize noise, feel free to reopen if comments are addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #4450
Short description of the changes
Due to concurrency, it is not guaranteed that which one of the second span and third span will be dropped in the test or both could be dropped. But it is guaranteed that at least one of them will be dropped.
Update the test to set a boolean flag when any span is dropped.
Welcome to suggestion!