[tracegen] Switch from Jaeger Client to OTEL SDK #4189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
added
the
changelog:breaking-change
5 tasks
Codecov ReportBase: 97.10% // Head: 97.09% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4189 +/- ##
==========================================
- Coverage 97.10% 97.09% -0.01%
==========================================
Files 301 301
Lines 17674 17674
==========================================
- Hits 17162 17161 -1
- Misses 412 413 +1
Partials 100 100
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
shubbham1215
pushed a commit
to shubbham1215/jaeger
that referenced
this pull request
Feb 22, 2023
## Which problem is this PR solving? - Part of migrating away from deprecated Jaeger Go SDK ## Short description of the changes - switch tracegen from Jaeger Client to OTEL SDK - a breaking change in some respect: - default exporter changed to Jaeger HTTP - different environment variables are used to configure exporters - debug and firehose flags are no longer set in the trace context, but as span attributes - no more metrics from tracegen Signed-off-by: Yuri Shkuro <github@ysh.us>
shubbham1215
pushed a commit
to shubbham1215/jaeger
that referenced
this pull request
Mar 5, 2023
## Which problem is this PR solving? - Part of migrating away from deprecated Jaeger Go SDK ## Short description of the changes - switch tracegen from Jaeger Client to OTEL SDK - a breaking change in some respect: - default exporter changed to Jaeger HTTP - different environment variables are used to configure exporters - debug and firehose flags are no longer set in the trace context, but as span attributes - no more metrics from tracegen Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: shubbham1215 <sawaikershubham@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
Breaking change
tracegen