Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watch directories for certificate hot-reload #4159

Merged
merged 3 commits into from
Jan 16, 2023
Merged

Watch directories for certificate hot-reload #4159

merged 3 commits into from
Jan 16, 2023

Commits on Jan 16, 2023

  1. Watch directories for certificate hot-reload 

    Instead of adding inotify watches on files, which mostly get removed during
certificate renewal, add watches for the parent directories and consider
inotify events only as indication that some of the files might have changed.

The change is required for the most typical atomic file update schemes,
for example for the scheme used by Kubernetes to update secret volumes.

Signed-off-by: Tero Saarni <tero.saarni@est.tech>
    @tsaarni
    tsaarni committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    07dde79 View commit details
    Browse the repository at this point in the history

  2. DRY code & test 

    Signed-off-by: Yuri Shkuro <github@ysh.us>
    @yurishkuro @tsaarni
    yurishkuro authored and tsaarni committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    3003b1c View commit details
    Browse the repository at this point in the history

  3. DRY tests 

    Signed-off-by: Yuri Shkuro <github@ysh.us>
    @yurishkuro @tsaarni
    yurishkuro authored and tsaarni committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    a5bb77e View commit details
    Browse the repository at this point in the history