Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define Health Server for GRPC servers #3712

Merged
merged 1 commit into from
May 30, 2022
Merged

Define Health Server for GRPC servers #3712

merged 1 commit into from
May 30, 2022

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented May 30, 2022

Which problem is this PR solving?

Short description of the changes

  • Add a grpc.health.v1.Health service to grpc collector and grpc query

Signed-off-by: Matthieu MOREL mmorel-35@users.noreply.github.com

@mmorel-35 mmorel-35 requested a review from a team as a code owner May 30, 2022 09:29
@mmorel-35 mmorel-35 requested a review from yurishkuro May 30, 2022 09:29
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #3712 (6695f8b) into main (b708823) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3712   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files         269      269           
  Lines       15842    15856   +14     
=======================================
+ Hits        15435    15450   +15     
  Misses        322      322           
+ Partials       85       84    -1     
Impacted Files Coverage Δ
cmd/collector/app/server/grpc.go 88.46% <100.00%> (+1.79%) ⬆️
cmd/query/app/server.go 94.44% <100.00%> (+0.18%) ⬆️
pkg/config/tlscfg/cert_watcher.go 92.63% <0.00%> (-2.11%) ⬇️
cmd/query/app/static_handler.go 97.60% <0.00%> (+1.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b708823...6695f8b. Read the comment docs.

Signed-off-by: Matthieu MOREL <mmorel-35@users.noreply.github.com>
@yurishkuro yurishkuro merged commit 22e9143 into jaegertracing:main May 30, 2022
@yurishkuro
Copy link
Member

Thanks

@mmorel-35 mmorel-35 deleted the grpc-health-check branch May 30, 2022 14:31
albertteoh pushed a commit to albertteoh/jaeger that referenced this pull request Jul 13, 2022
Signed-off-by: Albert Teoh <see.kwang.teoh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gRPC health check - AWS ECS
2 participants