Add CLI Option for gRPC Max Receive Message Size #3211
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3211 +/- ##
=======================================
Coverage 95.90% 95.91%
=======================================
Files 242 242
Lines 14786 14794 +8
=======================================
+ Hits 14181 14190 +9
Misses 525 525
+ Partials 80 79 -1
Continue to review full report at Codecov.
|
js8080
force-pushed
the
master
branch
3 times, most recently
from
26c40f5
to
6d4cf49
Compare
Added a new CLI option for the gRPC Collector to override the default max receive message size which is normally 4MB since some users of Jaeger may want to record Spans which exceed the default max size. Signed-off-by: Justin Stauffer <justin@epic.com>
Changed collector.grpc-max-receive-message-length to collector.grpc.max-receive-message-length for consistency. Signed-off-by: Justin Stauffer <justin@epic.com>
cmd/collector/app/builder_flags.go
Outdated
| collectorZipkinAllowedHeaders = "collector.zipkin.allowed-headers" | ||
| collectorZipkinAllowedOrigins = "collector.zipkin.allowed-origins" | ||
| collectorZipkinHTTPHostPort = "collector.zipkin.host-port" | ||
| collectorGRPCMaxReceiveMessageLength = "collector.grpc.max-receive-message-length" |
There was a problem hiding this comment.
given that we already have a grouping collector.grpc-server, I think a better name would be
collector.grpc-server.max-message-size
|
You would need to raise the PR from another branch of your fork (other than master) to fix these CI failures. |
Oh, shoot... I didn't realize that. Should I just delete this whole PR and then re-do it? |
Changes new option from `collector.grpc.max-receive-message-length` to `collector.grpc-server.max-message-size` as suggested during review. Signed-off-by: Justin Stauffer <justin@epic.com>
I made a new PR in #3214 from a branch on my fork instead of from master. Closing this PR. |
Which problem is this PR solving?
Resolves #3210
Short description of the changes
Added a new CLI option for the gRPC Collector to override the default
max receive message size which is normally 4MB since some users of
Jaeger may want to record Spans which exceed the default max size.
Signed-off-by: Justin Stauffer justin.stauffer@gmail.com