Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ppc64le support on multiarch docker images #3160

Merged
merged 4 commits into from
Jul 22, 2021

Conversation

krishvoor
Copy link
Contributor

Signed-off-by: Krishna Harsha Voora krishvoor@in.ibm.com

Which problem is this PR solving?

Re-adding the support for ppc64le arch, as it was missing in the following files.

Short description of the changes

  • updates docker/Makefile, scripts/build-all-in-one-image.sh, scripts/build-upload-docker-images.sh, scripts/hotrod-intergration-test.sh & docker/debug/Dockerfile

krishvoor and others added 3 commits July 20, 2021 07:29
Signed-off-by: Krishna Harsha Voora <krishvoor@in.ibm.com>
Signed-off-by: Krishna Harsha Voora <krishvoor@in.ibm.com>
@krishvoor
Copy link
Contributor Author

@yurishkuro @jpkrohling request for your review.

@jpkrohling
Copy link
Contributor

Same problem?

+ echo 'build docker images and upload to dockerhub/quay.io, BRANCH=master'
+ bash scripts/docker-login.sh
+ DOCKERHUB_USERNAME=jaegertracingbot
+ DOCKERHUB_TOKEN=
+ QUAY_USERNAME=jaegertracing+github_workflows
+ QUAY_TOKEN=
+ echo 'Performing a '\''docker login'\'' for DockerHub'
+ docker login -u jaegertracingbot docker.io --password-stdin
+ echo ''
Error: Cannot perform an interactive login from a non TTY device

I have no idea what's going on...

@yurishkuro yurishkuro enabled auto-merge (squash) July 22, 2021 14:31
@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #3160 (51f4459) into master (f8a6b3c) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3160      +/-   ##
==========================================
+ Coverage   95.91%   95.93%   +0.02%     
==========================================
  Files         239      239              
  Lines       14647    14647              
==========================================
+ Hits        14048    14051       +3     
+ Misses        521      519       -2     
+ Partials       78       77       -1     
Impacted Files Coverage Δ
pkg/config/tlscfg/cert_watcher.go 92.63% <0.00%> (-2.11%) ⬇️
...lugin/sampling/strategystore/adaptive/processor.go 100.00% <0.00%> (+0.64%) ⬆️
cmd/query/app/static_handler.go 97.60% <0.00%> (+1.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8a6b3c...51f4459. Read the comment docs.

@yurishkuro yurishkuro merged commit 9f0c71b into jaegertracing:master Jul 22, 2021
@krishvoor krishvoor deleted the private-ppc64le branch July 22, 2021 14:53
@vprithvi vprithvi added this to the Release 1.25.0 milestone Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants