Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Show* TLS configs #3106

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

albertteoh
Copy link
Contributor

Signed-off-by: albertteoh albert.teoh@logz.io

Which problem is this PR solving?

Short description of the changes

  • Removes the redundant Show* TLS config flags, which appear to all be true and don't seem to have changed for months (in some cases, years) since its introduction, and cannot see evidence where this could be changed by users via config parameters; i.e. it can only be changed in code.
  • If there is still a use case for keeping these flags, please advise and I suggest we document these reasons in a sensible place somewhere in code.

Signed-off-by: albertteoh <albert.teoh@logz.io>
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #3106 (d323bab) into master (4af24f2) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3106      +/-   ##
==========================================
- Coverage   95.94%   95.92%   -0.02%     
==========================================
  Files         236      236              
  Lines       10251    10238      -13     
==========================================
- Hits         9835     9821      -14     
- Misses        345      346       +1     
  Partials       71       71              
Impacted Files Coverage Δ
cmd/agent/app/reporter/grpc/flags.go 100.00% <ø> (ø)
cmd/collector/app/builder_flags.go 100.00% <ø> (ø)
cmd/query/app/flags.go 100.00% <ø> (ø)
pkg/config/tlscfg/flags.go 100.00% <100.00%> (ø)
plugin/metrics/prometheus/options.go 100.00% <100.00%> (ø)
plugin/storage/cassandra/options.go 100.00% <100.00%> (ø)
plugin/storage/es/options.go 100.00% <100.00%> (ø)
plugin/storage/integration/integration.go 77.34% <0.00%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4af24f2...d323bab. Read the comment docs.

@albertteoh albertteoh marked this pull request as ready for review June 25, 2021 05:01
@albertteoh albertteoh requested a review from a team as a code owner June 25, 2021 05:01
@albertteoh albertteoh requested a review from vprithvi June 25, 2021 05:01
@albertteoh albertteoh merged commit 51e5104 into jaegertracing:master Jun 25, 2021
@albertteoh albertteoh deleted the remove-show-enabled branch June 25, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing Show* TLS config flags
2 participants