Allow the ILM policy name to be configurable #2971
Conversation
- Add an option --ilm-policy-name to esmapping-generator; - Set the mapping's option in the rollover script (using an env var ES_ILM_POLICY_NAME). The policy's name defaults to jaeger-ilm-policy (both in the mapping generator and in the rollover script), so no breaking changes are added. Signed-off-by: Ricardo Ribeiro <j.ribeiro.fafe@gmail.com>
|
@jrRibeiro I am not sure our CI covers this part of ES maintenance, did you do some manual testing? If so could you post some test results / evidence? |
Codecov Report
@@ Coverage Diff @@
## master #2971 +/- ##
==========================================
- Coverage 95.97% 95.95% -0.02%
==========================================
Files 223 223
Lines 9712 9718 +6
==========================================
+ Hits 9321 9325 +4
- Misses 324 326 +2
Partials 67 67
Continue to review full report at Codecov.
|
Signed-off-by: Ricardo Ribeiro <j.ribeiro.fafe@gmail.com>
Yes I did some manual testing but it's better to actually test the change as part of the integration tests of the index rollover. I just added a new integration test (and refactored the tests a bit) to test both the default ILM policy name (to make sure that not setting the env var still works) and also a new test to set the env var and test if the ILM policy associated with the created indices matches the one we define. |
There was a problem hiding this comment.
LGTM
@albertteoh can you take a look at the integration test changes?
mergify
bot
dismissed stale reviews from yurishkuro and albertteoh
Pull request has been modified.
|
Thanks @jrRibeiro! |
Thank you @yurishkuro and @albertteoh! |
Which problem is this PR solving?
Short description of the changes
--ilm-policy-nametoesmapping-generator, to set the policy name in the mappings file;ES_ILM_POLICY_NAME).jaeger-ilm-policy(both in the mapping generator and in theinitaction of the rollover script), so no breaking changes are added.