Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type conversion #2921

Merged
merged 2 commits into from
Apr 5, 2021
Merged

Conversation

jinglina
Copy link
Contributor

@jinglina jinglina commented Apr 5, 2021

fix redundant type conversion

@jinglina jinglina requested a review from a team as a code owner April 5, 2021 09:35
@jinglina jinglina requested a review from joe-elliott April 5, 2021 09:35
Signed-off-by: jinglina <jinglinax@163.com>
@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #2921 (a5bc125) into master (56af6b4) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2921      +/-   ##
==========================================
+ Coverage   95.91%   95.94%   +0.03%     
==========================================
  Files         223      223              
  Lines        9708     9708              
==========================================
+ Hits         9311     9314       +3     
+ Misses        328      325       -3     
  Partials       69       69              
Impacted Files Coverage Δ
model/converter/thrift/jaeger/from_domain.go 100.00% <100.00%> (ø)
plugin/storage/integration/integration.go 77.90% <0.00%> (+0.55%) ⬆️
...lugin/sampling/strategystore/adaptive/processor.go 100.00% <0.00%> (+0.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56af6b4...a5bc125. Read the comment docs.

yurishkuro
yurishkuro previously approved these changes Apr 5, 2021
@mergify mergify bot dismissed yurishkuro’s stale review April 5, 2021 14:17

Pull request has been modified.

@yurishkuro yurishkuro merged commit 33e8e96 into jaegertracing:master Apr 5, 2021
@jpkrohling jpkrohling added this to the Release 1.23.0 milestone Jun 4, 2021
@jinglina jinglina deleted the fixtypeconverter branch June 18, 2021 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants