Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove downsample flags from the query service #2782

Merged
merged 3 commits into from
Feb 4, 2021

Conversation

joe-elliott
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • Splits the storage factory AddFlags method into two: AddFlags and AddFlagsPipeline with the latter meant to be used by Jaeger span pipeline processors (ingesters, distributors).
  • Add appropriate tests

Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott joe-elliott requested a review from a team as a code owner February 3, 2021 17:31
@mergify mergify bot requested a review from jpkrohling February 3, 2021 17:31
@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #2782 (1b6618d) into master (84b6f34) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2782      +/-   ##
==========================================
+ Coverage   95.83%   95.89%   +0.05%     
==========================================
  Files         217      217              
  Lines        9634     9640       +6     
==========================================
+ Hits         9233     9244      +11     
+ Misses        330      327       -3     
+ Partials       71       69       -2     
Impacted Files Coverage Δ
plugin/storage/factory.go 98.18% <100.00%> (+0.10%) ⬆️
cmd/query/app/server.go 97.12% <0.00%> (+1.43%) ⬆️
cmd/query/app/static_handler.go 95.16% <0.00%> (+2.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84b6f34...1b6618d. Read the comment docs.

Signed-off-by: Joe Elliott <number101010@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downsampling in query service?
3 participants