Add github action for elasticsearch otel integration tests #2671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2671 +/- ##
==========================================
+ Coverage 95.55% 95.57% +0.02%
==========================================
Files 214 214
Lines 9535 9535
==========================================
+ Hits 9111 9113 +2
+ Misses 346 344 -2
Partials 78 78
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Nov 30, 2020
Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com>
Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com>
Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com>
yurishkuro
reviewed
Dec 1, 2020
yurishkuro
reviewed
Dec 1, 2020
Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com>
|
Hi @yurishkuro Updated the PR with the feedback. Thank you. |
yurishkuro
reviewed
Dec 1, 2020
There was a problem hiding this comment.
Refactoring looks great!
I'm seeing that error again: fatal: No names found, cannot describe anything. https://github.com/jaegertracing/jaeger/pull/2671/checks?check_run_id=1477915552#step:5:1338
Nice catch. |
Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com>
Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com>
yurishkuro
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashmita Bohara ashmita.bohara152@gmail.com
Which problem is this PR solving?
Adds integration test for Elasticsearch OpenTelemetry.
Part of #2645
Short description of the changes
Also refactors es-integration-test.sh to accept arg either "default" or "otel" otherwise fails.