Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Badger to v1.6.2 #2613

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Conversation

Ackar
Copy link
Contributor

@Ackar Ackar commented Nov 3, 2020

Which problem is this PR solving?

Short description of the changes

  • Bump Badger to v1.6.2

@Ackar Ackar requested a review from a team as a code owner November 3, 2020 22:10
@Ackar Ackar requested a review from objectiser November 3, 2020 22:10
Signed-off-by: Sylvain Cleymans <sylvain@movio.co>
@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #2613 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2613      +/-   ##
==========================================
- Coverage   95.07%   95.05%   -0.03%     
==========================================
  Files         209      209              
  Lines        9364     9364              
==========================================
- Hits         8903     8901       -2     
- Misses        385      386       +1     
- Partials       76       77       +1     
Impacted Files Coverage Δ
plugin/storage/badger/factory.go 95.78% <100.00%> (ø)
plugin/storage/badger/spanstore/reader.go 95.37% <100.00%> (ø)
cmd/query/app/server.go 88.52% <0.00%> (-1.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a0d8cc...7d68d8b. Read the comment docs.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but maybe @burmanm can take a look?

Copy link
Contributor

@objectiser objectiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM also, but will wait to see if @burmanm has any comment.

@burmanm
Copy link
Contributor

burmanm commented Nov 4, 2020

Should solve some issues, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants