Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing build instruction #1887 #2542

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

listaction
Copy link
Contributor

Adding missing build instruction that allows jaeger binaries to be built.

@listaction listaction requested a review from a team as a code owner October 8, 2020 15:46
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@yurishkuro
Copy link
Member

Please makes sure the commit is signed.

@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #2542 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2542      +/-   ##
==========================================
- Coverage   95.37%   95.35%   -0.03%     
==========================================
  Files         208      208              
  Lines        9248     9248              
==========================================
- Hits         8820     8818       -2     
- Misses        352      353       +1     
- Partials       76       77       +1     
Impacted Files Coverage Δ
cmd/query/app/static_handler.go 82.56% <0.00%> (-1.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 873397e...d0803ba. Read the comment docs.

Adding missing build instruction that allows jaeger binaries to be built.

Signed-off-by: karthik <listaction@gmail.com>
@yurishkuro yurishkuro merged commit 600d023 into jaegertracing:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants