Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose tunning options via expvar #2496

Merged
merged 12 commits into from
Oct 5, 2020
Merged

Expose tunning options via expvar #2496

merged 12 commits into from
Oct 5, 2020

Commits on Oct 5, 2020

  1. Expose tunning options via expvar 

    Always mount expvar /debug/vars handler
regardless of chosen metrics backend.

Store the following collector's options in expvar:
- collector.num-workers
- collector.queue-size

Store the following agent's options in expvar:
- processor.*.server-max-packet-size
- processor.*.server-queue-size
- processor.*.workers

Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
    @dstdfx
    dstdfx committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    bffbf4d View commit details
    Browse the repository at this point in the history

  2. Code clean up 

    Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
    @dstdfx
    dstdfx committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    5348411 View commit details
    Browse the repository at this point in the history

  3. Fix tunning options exposion 

    Put expvar logic into private funcs of builders.

Use different values in tests.

Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
    @dstdfx
    dstdfx committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    d682169 View commit details
    Browse the repository at this point in the history

  4. Expose additional storage options 

    Store following storage-related options in expvar:
- memory.max-traces
- downsampling.ratio

Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
    @dstdfx
    dstdfx committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    1d19d1d View commit details
    Browse the repository at this point in the history

  5. Call setExpvarOptions method inside Initialize 

    Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
    @dstdfx
    dstdfx committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    6bed030 View commit details
    Browse the repository at this point in the history

  6. Add span-storage.type options 

    Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
    @dstdfx
    dstdfx committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    772135b View commit details
    Browse the repository at this point in the history

  7. Fix test and expvar type 

    Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
    @dstdfx
    dstdfx committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    7a55c64 View commit details
    Browse the repository at this point in the history

  8. Fix falling test 

    Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
    @dstdfx
    dstdfx committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    86296f7 View commit details
    Browse the repository at this point in the history

  9. Use fork.Factory to store internal options 

    Delete direct expvar calls.

Vendor latest jaeger-lib.

Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
    @dstdfx
    dstdfx committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    7e97b22 View commit details
    Browse the repository at this point in the history

  10. Fix factory init, rename opts func 

    Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
    @dstdfx
    dstdfx committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    0463d3b View commit details
    Browse the repository at this point in the history

  11. Update jaeger-lib to v2.4.0 

    Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
    @dstdfx
    dstdfx committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    9e54b11 View commit details
    Browse the repository at this point in the history

  12. Clean deps 

    Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
    @dstdfx
    dstdfx committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    e877351 View commit details
    Browse the repository at this point in the history