Clarify that "kafka" is not a real storage backend #2066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #2066 +/- ##
=======================================
Coverage 97.42% 97.43%
=======================================
Files 209 209
Lines 10340 10351 +11
=======================================
+ Hits 10074 10085 +11
Misses 223 223
Partials 43 43 Continue to review full report at Codecov.
|
vprithvi
reviewed
Feb 10, 2020
cmd/env/command.go
Outdated
| ` | ||
| storageTypeDescription = `The type of backend [%s] used for trace storage. | ||
| Multiple backends can be specified as comma-separated list, e.g. "cassandra,elasticsearch" | ||
| (currently only for writing spans). Note that "kafka" is not a real storage backend, it is |
There was a problem hiding this comment.
I'd rephrase this to say "kafka" is distributed queue and not a complete storage solution and is expected to be used in conjunction with ingester.
vprithvi
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address user questions like: